Author:
Date:
Subject:
Pierre Ossman
2008-07-21 00:40:33
Re: linux-next: Tree for July 16 (crash on quad core AMD)
On Sat, 19 Jul 2008 23:03:35 +0900
Tejun Heo <[email protected]> wrote:
> Pierre Ossman wrote:
> > On Sat, 19 Jul 2008 11:12:17 +0900
> > Tejun Heo <[email protected]> wrote:
> >
> >> Oh... I see. How about adding sg_miter_consume(@miter, @bytes)? If the
> >> function is never called, the whole chunk is assumed to be consumed. If
> >> the function is called only @bytes are consumed.
> >>
> >
> > Sounds reasonable. Care to make an independent patch so that I can
> > continue my PIO hacking adventures? :)
>
> Sure thing. Here you go. :-)
>
> Subject: [PATCH 2.6.26] sg: reimplement sg mapping iterator
>
I've converted my code to use your implementation instead, and it seems
to be working perfectly.
How comfortable to you feel about your patch? :)
This fixes a big problem in the sdhci driver where falling back on PIO
(because of hw DMA bugs) would create lots of potential issues as the
driver couldn't access highmem pages. I'd like to get this fix in for
2.6.27, which means that your patch also needs to go in now.
Rgds
--
-- Pierre Ossman
WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.
Author:
Date:
Subject:
Tejun Heo
2008-07-21 09:38:36
Re: linux-next: Tree for July 16 (crash on quad core AMD)
Hello, Pierre.
Pierre Ossman wrote:
> I've converted my code to use your implementation instead, and it seems
> to be working perfectly.
Cool.
> How comfortable to you feel about your patch? :)
I think it should be okay (well, of course :-) and tested a few corner
cases by modifying the copy function.
> This fixes a big problem in the sdhci driver where falling back on PIO
> (because of hw DMA bugs) would create lots of potential issues as the
> driver couldn't access highmem pages. I'd like to get this fix in for
> 2.6.27, which means that your patch also needs to go in now.
I think it needs an ACK from Jens. Jens?
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Author:
Date:
Subject:
Pierre Ossman
2008-07-21 13:32:09
Re: linux-next: Tree for July 16 (crash on quad core AMD)
On Mon, 21 Jul 2008 09:38:36 +0900
Tejun Heo <[email protected]> wrote:
>
> I think it needs an ACK from Jens. Jens?
>
He seems to be on vacation. I sent him a review request for my original
code a couple of weeks ago, and I haven't heard anything. marc.info
also doesn't show anything since the 3rd. Odds are he won't be back
during the merge window. :/
--
-- Pierre Ossman
WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.
|
